[OE-core] [PATCH 3/3] selftest/containerimage.py: Add container IMAGE_FSTYPES test

Randy Witt randy.e.witt at linux.intel.com
Thu Jan 19 22:50:16 UTC 2017


On 01/19/2017 04:01 AM, Burton, Ross wrote:
> On 18 January 2017 at 18:31, Randy Witt <randy.e.witt at linux.intel.com>
> wrote:
>
>> +        expected_files = [
>> +                    './',
>> +                    './bin/',
>> +                    './bin/theapp',
>> +                    './etc/',
>> +                    './etc/default/',
>> +                    './etc/default/postinst',
>> +                    './etc/ld.so.cache',
>> +                    './etc/timestamp',
>> +                    './etc/version',
>> +                    './run/',
>> +                    './var/',
>> +                    './var/cache/',
>> +                    './var/cache/ldconfig/',
>> +                    './var/cache/ldconfig/aux-cache',
>> +                    './var/cache/opkg/',
>> +                    './var/lib/',
>> +                    './var/lib/opkg/'
>> +                ]
>>
>> These should use ${bindir} etc so they're resilient to distros changing
> the paths (please use get_bb_vars() to only invoke bitbake once).
>
> +        image = os.path.join(self.builddir, "tmp/deploy/images/qemux86/
>> container-test-image-qemux86.tar.bz2")
>>
>
> Don't hardcode this path, use ${DEPLOY_DIR_IMAGE} (fetch it with the paths
> above for speed) which will get you to tmp/deploy/images/[machine].  Again,
> these paths can change (poky sets TMPDIR to tmp, nodistro uses
> tmp-${TCLIBC}).
>
> Ross
>

I just sent a v2, but screwed up the subject. I'll resend the whole series again 
even though only 3/3 changed, to hopefully make it easier on you.




More information about the Openembedded-core mailing list