[OE-core] [PATCH] qemu: Upgrade to 2.7.1

Alexander Kanavin alexander.kanavin at linux.intel.com
Fri Jan 20 11:48:02 UTC 2017


On 01/20/2017 01:35 PM, Patrick Ohly wrote:
> On Thu, 2017-01-19 at 16:46 -0600, Aníbal Limón wrote:
>>  SRC_URI_prepend = "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
>> -SRC_URI[md5sum] = "08d4d06d1cb598efecd796137f4844ab"
>> -SRC_URI[sha256sum] = "326e739506ba690daf69fc17bd3913a6c313d9928d743bd8eddb82f403f81e53"
>> +SRC_URI[md5sum] = "a315bc51ed443a08d2cf1416d76b9ab4"
>> +SRC_URI[sha256sum] = "68636788eb69bcb0b44ba220b32b50495d6bd5712a934c282217831c4822958f"
>
> _prepend without trailing space is broken. It just happens to work
> because the SRC_URI it prepends to usually has a leading space.
>
> I just ran into a situation where it didn't (due to some _remove
> operation being interposed, which did a split/join, see YOCTO #10945).
>
> I was about to send a fix, but it would just conflict with your version
> update. Can you include a fix by revising your proposal, perhaps by
> turning it into a patch series with two changes?
>
> IMHO SRC_URI =+ "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
> should be fine. There's no need for the more complex _prepend.

Actually, this line should be simply moved to qemu.inc and placed 
together with other SRC_URI entries. There is nothing version-specific 
in it. All these prepends, appends and +='s are best avoided if possible.

Alex




More information about the Openembedded-core mailing list