[OE-core] [PATCH v4 05/12] ovmf: deploy firmware in image directory

[Patrick Ohly]

On Sun, 2017-01-22 at 23:23 -0800, Ricardo Neri wrote:
> On Fri, 2017-01-20 at 15:12 +0100, Patrick Ohly wrote:
> > The traditional usage of ovmf via the qemu bios parameter is no longer
> > supported
> 
> I don't see dropping support for this option in this series.
>
>  Is part of
> another series? I just checked the poky repo and I still the the option
> supported. Or do you mean that only the ovmf recipe will not support
> exporting bios.bin?

Yes, the latter.

> > and therefore it is not necessary to create a "bios.bin"
> > file in the target sysroot.
> 
> Wouldn't this particular part of the patch break the existing runqemu.
> If this is the case, perhaps the last patch (or a patch towards the end
> of the series) can remove this functionality in both places.

Could be done, but personally I prefer to add something new before
taking away the old approach. This might not be applicable here (because
there is no other bios), but it still "feels" safer.

> On the other hand, this is a new recipe and this may not be super
> critical. Especially if you meant that only OVMF will not support
> installing bios.bin in sysroot. Maybe all is needed is some
> clarification in the commit message.

Care to suggest something? ;-) To me, "traditional usage of ovmf ... is
no longer supported" already says that this is a statement about ovmf,
not the bios parameter, so I'm not sure how to reword this.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.