[OE-core] [PATCH 2/4] libtasn1: Upgrade 4.9 -> 4.10

Maxin B. John maxin.john at intel.com
Thu Jan 26 17:11:30 UTC 2017


Hi Ross,

>On Thu, Jan 26, 2017 at 10:20:16AM +0000, Burton, Ross wrote:
>>On 23 January 2017 at 09:58, Maxin B. John <maxin.john at intel.com> wrote:
>>
>>    Removed the following Backported patches:
>>         1. 0001-configure-don-t-add-Werror-to-build-flags.patch
>
> This breaks on musl in the most amusing way:
>
> |                  from ../../libtasn1-4.10/gl/getopt.c:28:
> | ./stdint.h:89:5: error: #if with no expression
> |  #if
> |      ^
>

For some strange reasons, this build error hasn't occured in my musl
test build before sending the patch. 

> When it says stdint.h it doesn't mean the system stdint.h because that
> would be too sensible.  libtasn1 uses gnulib which writes its own system
> headers, so this is in fact build/gl/stdint.h which does indeed just 
> do '#if '.  The source for this file is gl/stdint.in.h in this block:
>
> /* Override WINT_MIN and WINT_MAX if gnulib's <wchar.h> or <wctype.h> overrides
> wint_t.  */
> #if @GNULIB_OVERRIDES_WINT_T@
> # undef WINT_MIN
> # undef WINT_MAX
> # define WINT_MIN 0x0U
> # define WINT_MAX 0xffffffffU
> #endif
>
>For some reason when this executes @GNULIB_OVERRIDES_WINT_T@ isn't defined.

The build error is due to this change:
http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=5a400b3f5a1f5483dbfd75d38bdb7080218a063b

*  m4/stdint.m4 (gl_STDINT_H): Don't define GNULIB_OVERRIDES_WINT_T.

will send a v2 to fix this.

>Cheers,
>Ross

Thanks and Regards,
Maxin



More information about the Openembedded-core mailing list