[OE-core] [PATCH] systemd: respect USE_LDCONFIG when setting default PACKAGECONFIG

[Andre McCurdy]

On Thu, Jan 26, 2017 at 10:18 PM, Khem Raj <raj.khem at gmail.com> wrote:
> On Thu, Jan 26, 2017 at 8:06 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>> Avoid trying to call ldconfig at run-time in distros which force
>> USE_LDCONFIG to 0 and therefore don't provide it.
>>
>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> ---
>>  meta/recipes-core/systemd/systemd_232.bb | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/systemd/systemd_232.bb b/meta/recipes-core/systemd/systemd_232.bb
>> index cc8781e..cfe6958 100644
>> --- a/meta/recipes-core/systemd/systemd_232.bb
>> +++ b/meta/recipes-core/systemd/systemd_232.bb
>> @@ -39,8 +39,10 @@ SRC_URI_append_libc-uclibc = "\
>>  "
>>  SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"
>>
>> +USE_LDCONFIG ?= "1"
>
> now that we have more recipes using this variables. I think it should
> to global config space. May be have it as a DISTRO_FEATURE is more
> appropriate

Patches for both approaches have now been sent to the list.

>> +
>>  PACKAGECONFIG ??= "xz \
>> -                   ldconfig \
>> +                   ${@base_conditional('USE_LDCONFIG', '1', 'ldconfig', '', d)} \
>>                     ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \
>>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
>>                     ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core