[OE-core] [PATCH] cairo: fix QA Issue

Burton, Ross ross.burton at intel.com
Mon Jul 3 13:56:20 UTC 2017


On 3 July 2017 at 13:34, Gordan Markuš <gordan.markus at pelagicore.com> wrote:

> -FILES_${PN}-dev += "${libdir}/cairo/*.so"
> +FILES_${PN}-dev += "${libdir}/cairo ${libdir}/cairo/*.so"
>

I just spent five minutes working out *why* this fixes the QA issue you
were getting.

A better fix would be to delete ${libdir}/cairo using:

  rmdir ${libdir}/cairo || :

or

  rmdir --ignore-fail-on-non-empty ${libdir}/cairo

(former is POSIX compliant, but I can't think of a situation where that is
only a hypothetical problem)

Then in the commit message you can say that the directory is always created
but it only has content if you disable cairo-trace.  At least, I hope you
are explicitly disabling cairo-trace as there's no other way I can see for
you go get this.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170703/c657794c/attachment-0002.html>


More information about the Openembedded-core mailing list