[OE-core] [PATCH] meta: move image-mklibs image-prelink to IMAGE_CLASSES

[Ming Liu]

Hi, Christopher:

I am on board, using '+=' in local.conf.sample.extended is a good idea, I
will send a V2 soon.

the best,
thank you

2017-07-06 17:20 GMT+02:00 Christopher Larson <kergoth at gmail.com>:

>
>
> On Thu, Jul 6, 2017 at 7:40 AM, <liu.ming50 at gmail.com> wrote:
>
>> From: Ming Liu <peter.x.liu at external.atlascopco.com>
>>
>> The code logic in image-mklibs.bbclass and image-prelink.bbclass is all
>> about optimizing the rootfs image, so it makes more sense to put them
>> into IMAGE_CLASSES rather than USER_CLASSES.
>>
>> What's more, this fixes a potential issue by moving out image-mklibs
>> from INHERIT, considering that, a following dependency is missing in
>> image-mklibs.bblcass:
>> ...
>> do_rootfs[depends] += "virtual/${MLPREFIX}${TARGET_P
>> REFIX}binutils:do_populate_sysroot"
>>
>
> This removes the example usage of IMAGE_CLASSES to alter the default image
> types inclusion in local.conf.sample.extended, but doesn’t replace it with
> anything, and the commit message doesn’t mention it. Either find a way to
> fix that example (i.e. use += or something) or at least mention that you’re
> removing it, particularly since adding image types is currently the most
> common reason to alter that variable.
> --
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170707/025df1a8/attachment-0002.html>