[OE-core] [PATCH 18/30] oeqa/selftest/cases: tinfoil to run in the main thread

Aníbal Limón anibal.limon at linux.intel.com
Wed Jul 12 14:55:23 UTC 2017



On 07/12/2017 01:56 AM, Patrick Ohly wrote:
> On Tue, 2017-07-11 at 15:23 -0500, Aníbal Limón wrote:
>> The tinfoil tests needs to initialize bitbake internals and wasn't
>> designed to be in a thread environment causing problems when try
>> for example set signal handlers in a thread different than the
>> main one.
>>
>> To workaround this execute tinfoil tests in the main thread and
>> don't use custom builddir because isn't make sense too.
>>
>> Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
>> ---
>>  meta/lib/oeqa/selftest/cases/tinfoil.py | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/lib/oeqa/selftest/cases/tinfoil.py
>> b/meta/lib/oeqa/selftest/cases/tinfoil.py
>> index aa1af7e0423..7248b755812 100644
>> --- a/meta/lib/oeqa/selftest/cases/tinfoil.py
>> +++ b/meta/lib/oeqa/selftest/cases/tinfoil.py
>> @@ -9,7 +9,6 @@ from oeqa.core.decorator.oeid import OETestID
>>  
>>  class TinfoilTests(OESelftestTestCase):
>>      """ Basic tests for the tinfoil API """
>> -
>>      @OETestID(1568)
>>      def test_getvar(self):
>>          with bb.tinfoil.Tinfoil() as tinfoil:
> 
> There's just a line removal in this patch. That's probably not what was
> intended?

Yes, thanks for pointing it, i changed the default behaviour to the old
one it means run by default into the main thread and uses the same build
dir, so this patch needs to be removed.

Cheers,
Anibal

> 



More information about the Openembedded-core mailing list