[OE-core] [PATCH 1/2] gpg_sign.py: fix overwriting the RPM macro __gpg in a wrong way

Lans Zhang lans.zhang2008 at gmail.com
Thu Jul 13 01:54:53 UTC 2017


Hi Robert,

Could you help me to review this RR?

Thanks,

Jia


On 07/11/2017 12:43 PM, Jia Zhang wrote:
> From: Lans Zhang <jia.zhang at windriver.com>
>
> The RPM macro used in --define option should not be prefixed by %%.
>
> Signed-off-by: Lans Zhang <jia.zhang at windriver.com>
> ---
>   meta/lib/oe/gpg_sign.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/gpg_sign.py b/meta/lib/oe/gpg_sign.py
> index 7ce767e..c53df54 100644
> --- a/meta/lib/oe/gpg_sign.py
> +++ b/meta/lib/oe/gpg_sign.py
> @@ -36,7 +36,7 @@ class LocalSigner(object):
>               gpg_args += ' --pinentry-mode=loopback'
>           cmd += "--define '_gpg_sign_cmd_extra_args %s' " % gpg_args
>           if self.gpg_bin:
> -            cmd += "--define '%%__gpg %s' " % self.gpg_bin
> +            cmd += "--define '__gpg %s' " % self.gpg_bin
>           if self.gpg_path:
>               cmd += "--define '_gpg_path %s' " % self.gpg_path
>   




More information about the Openembedded-core mailing list