[OE-core] [PATCH 01/30] oeqa/core/loader: Switch method definition for _make_failed_test

[Aníbal Limón]

On 07/14/2017 04:52 AM, Patrick Ohly wrote:
> On Tue, 2017-07-11 at 15:23 -0500, Aníbal Limón wrote:
>> This was a mistake of me to define wrong what methods needs
>> to be defined by certain python version.
>>
>> See rev d8380d098a290510b442a7abd2dd5a50cabf5844.
> 
> This will fix this error that we see in Refkit with current OE-core
> master, right?
> 
> 00:07:10.313 Traceback (most recent call last):
> 00:07:10.313   File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/scripts/oe-selftest", line 70, in <module>
> 00:07:10.313     ret = main()
> 00:07:10.313   File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/scripts/oe-selftest", line 57, in main
> 00:07:10.313     results = args.func(logger, args)
> 00:07:10.313   File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/selftest/context.py", line 215, in run
> 00:07:10.313     rc = self._internal_run(logger, args)
> 00:07:10.313   File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/selftest/context.py", line 176, in _internal_run
> 00:07:10.313     self.tc.loadTests(self.module_paths, **self.tc_kwargs['load'])
> 00:07:10.313   File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/core/context.py", line 51, in loadTests
> 00:07:10.313     self.suites = self.loader.discover()
> 00:07:10.313   File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/core/loader.py", line 286, in discover
> 00:07:10.313     pattern='*.py', top_level_dir=path)
> 00:07:10.313   File "/usr/lib64/python3.4/unittest/loader.py", line 275, in discover
> 00:07:10.313     tests = list(self._find_tests(start_dir, pattern))
> 00:07:10.313   File "/usr/lib64/python3.4/unittest/loader.py", line 327, in _find_tests
> 00:07:10.313     yield _make_failed_import_test(name, self.suiteClass)
> 00:07:10.313   File "/usr/lib64/python3.4/unittest/loader.py", line 39, in _make_failed_import_test
> 00:07:10.313     return _make_failed_test(name, ImportError(message), suiteClass)
> 00:07:10.313 TypeError: _make_failed_test() missing 1 required positional argument: 'suiteClass'
> 
> Can this particular patch please be merged into OE-core master
> independently from the patch series? It's not really related to it
> anyway.

Yes this will fix that error, showing the error into the case.

By default unittest module shows this kind of error at run step so it's
better for us to notice when a test case have syntax or modules missing
errors at load step.

Cheers,
Anibal

>