[OE-core] [oe-core][RESEND][PATCH 1/1] go: centralize definition of COMPATIBLE_HOST

[Khem Raj]

On Wed, Jul 26, 2017 at 3:14 PM, Joe Slater <jslater at windriver.com> wrote:
> Put it in goarch.bbclass which all go related recipes inherit.
>

looks ok

> Signed-off-by: Joe Slater <jslater at windriver.com>
> ---
>  meta/classes/go.bbclass               | 5 -----
>  meta/classes/goarch.bbclass           | 6 ++++++
>  meta/recipes-devtools/go/go-cross.inc | 4 ----
>  meta/recipes-devtools/go/go.inc       | 6 ------
>  4 files changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
> index 85f71a2..cedda68 100644
> --- a/meta/classes/go.bbclass
> +++ b/meta/classes/go.bbclass
> @@ -1,10 +1,5 @@
>  inherit goarch
>
> -# x32 ABI is not supported on go compiler so far
> -COMPATIBLE_HOST_linux-gnux32 = "null"
> -# ppc32 is not supported in go compilers
> -COMPATIBLE_HOST_powerpc = "null"
> -
>  GOROOT_class-native = "${STAGING_LIBDIR_NATIVE}/go"
>  GOROOT = "${STAGING_LIBDIR_NATIVE}/${TARGET_SYS}/go"
>  GOBIN_FINAL_class-native = "${GOROOT_FINAL}/bin"
> diff --git a/meta/classes/goarch.bbclass b/meta/classes/goarch.bbclass
> index 4a5b2ec..57537fb 100644
> --- a/meta/classes/goarch.bbclass
> +++ b/meta/classes/goarch.bbclass
> @@ -11,6 +11,12 @@ TARGET_GOARM = "${@go_map_arm(d.getVar('TARGET_ARCH', True), d.getVar('TUNE_FEAT
>  TARGET_GOTUPLE = "${TARGET_GOOS}_${TARGET_GOARCH}"
>  GO_BUILD_BINDIR = "${@['bin/${HOST_GOTUPLE}','bin'][d.getVar('BUILD_GOTUPLE',True) == d.getVar('HOST_GOTUPLE',True)]}"
>
> +# define here because everybody inherits this class
> +#
> +COMPATIBLE_HOST_linux-gnux32 = "null"
> +COMPATIBLE_HOST_powerpc = "null"
> +COMPATIBLE_HOST_powerpc64 = "null"
> +
>  def go_map_arch(a, d):
>      import re
>      if re.match('i.86', a):
> diff --git a/meta/recipes-devtools/go/go-cross.inc b/meta/recipes-devtools/go/go-cross.inc
> index 71e4611..1c2d9e3 100644
> --- a/meta/recipes-devtools/go/go-cross.inc
> +++ b/meta/recipes-devtools/go/go-cross.inc
> @@ -13,7 +13,3 @@ FILESEXTRAPATHS =. "${FILE_DIRNAME}/go-cross:"
>  GOROOT_FINAL = "${libdir}/go"
>  export GOROOT_FINAL
>
> -# x32 ABI is not supported on go compiler so far
> -COMPATIBLE_HOST_linux-gnux32 = "null"
> -# ppc32 is not supported in go compilers
> -COMPATIBLE_HOST_powerpc = "null"
> diff --git a/meta/recipes-devtools/go/go.inc b/meta/recipes-devtools/go/go.inc
> index 91d040d..52abbeb 100644
> --- a/meta/recipes-devtools/go/go.inc
> +++ b/meta/recipes-devtools/go/go.inc
> @@ -12,12 +12,6 @@ DEPENDS += "${@ 'libgcc' if not oe.utils.inherits(d, 'cross') else ''}"
>  INHIBIT_PACKAGE_STRIP = "1"
>  INHIBIT_SYSROOT_STRIP = "1"
>
> -# x32 ABI is not supported on go compiler so far
> -COMPATIBLE_HOST_linux-gnux32 = "null"
> -# ppc is not supported in go compilers
> -COMPATIBLE_HOST_powerpc = "null"
> -COMPATIBLE_HOST_powerpc64 = "null"
> -
>  export GOHOSTOS = "${BUILD_GOOS}"
>  export GOHOSTARCH = "${BUILD_GOARCH}"
>  export GOOS = "${TARGET_GOOS}"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core