[OE-core] [PATCH] image: Convert vmdk/vdi/qcow2 to strict CONVERSION_CMD types

Richard Purdie richard.purdie at linuxfoundation.org
Thu Jul 27 21:14:15 UTC 2017


On Thu, 2017-07-27 at 12:20 -0400, Tom Rini wrote:
> On Thu, Jul 27, 2017 at 04:08:40PM +0000, Wold, Saul wrote:
> > 
> > On Tue, 2017-07-25 at 15:58 -0400, Tom Rini wrote:
> > > 
> > > The vmdk/vdi/qcow2 IMAGE_FSTYPEs predate wic.  As such, they
> > > provide
> > > some similar underlying functionality in order to produce a
> > > "disk"
> > > image
> > > that in turn can be converted into different formats that various
> > > hypervisor types work with.  They do not however provide the
> > > ability
> > > for
> > > other disk image types to be converted into these same output
> > > types.
> > > Furthermore, they are less flexible than what wic does
> > > provide.  This
> > > drops the old style vmdk/vdi/qcow2 types and re-introduces them
> > > under
> > > the CONVERSION_CMD framework.  The equivalent of vmdk is now
> > > wic.vmdk
> > > and so forth for the other types.
> > > 
> > I like this also!  Strong work!
> > 
> > Would this allow us to further collapse the live-vm-common.bbclass
> > back
> > to just image-live.bbclass.  I know that the magic mapping that
> > happens
> > in set_live_vm_vars() has caused confusion in the past and removing
> > that mapping would be pretty awesome.
> Yes, with this there is only one user of live-vm-common.bbclass, so
> it could be folded back.

This patchset looks to have caused a number of selftest failures:

https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/409/steps/Running%20oe-selftest/logs/stdio

I suspect there are some testcases which need updating with this
change, would you be able to take a look please?

Cheers,

Richard






More information about the Openembedded-core mailing list