[OE-core] [PATCH] Fix return value checks from subprocess.call()'s

Mikko.Rapeli at bmw.de Mikko.Rapeli at bmw.de
Thu Jun 1 12:50:30 UTC 2017


On Thu, Jun 01, 2017 at 01:40:10PM +0100, Burton, Ross wrote:
> On 19 May 2017 at 08:17, Mikko Rapeli <mikko.rapeli at bmw.de> wrote:
> 
> >  bitbake/lib/bb/ui/ncurses.py             | 2 +-
> >  bitbake/lib/bb/utils.py                  | 2 +-
> >  meta/classes/archiver.bbclass            | 2 +-
> >  meta/classes/cml1.bbclass                | 2 +-
> >  meta/classes/kernel-module-split.bbclass | 2 +-
> >  meta/classes/sstate.bbclass              | 4 ++--
> >  meta/lib/oeqa/utils/buildproject.py      | 2 +-
> >  meta/lib/oeqa/utils/targetbuild.py       | 4 ++--
> >  meta/recipes-extended/cups/cups.inc      | 2 +-
> >  scripts/runqemu                          | 8 ++++----
> >
> 
> Poky is a generated repository and you've patches that touch two upstream
> repositories, can you split this into bitbake/ (for the bitbake repo) and
> meta/ scripts/ (for the openembedded-core repository).

Yes, I can do that.

> I presume the transformation wasn't automated and you checked that throwing
> exceptions was the right thing to do?

I did the changes manually and to me throwing an exception in those places
is the right thing to do instead of ignoring all errors.

I will send a v2.

-Mikko


More information about the Openembedded-core mailing list