[OE-core] [oe-core][PATCH 1/1] tcf-agent: correct CFLAGS

[Khem Raj]

On Fri, Jun 2, 2017 at 4:07 PM, Joe Slater <jslater at windriver.com> wrote:
> Modify CFLAGS for several cases which will not compile otherwise.
> Do not use the form CFLAGS_x_append because it will replace, not
> append to CFLAGS for override x.

actually the reason is that override and _append are exchanged. I see
the issue too here. I sent a patch just to fix the space issue but
this patch is better with one exception. please call the new variable
with call uppercase.

>
> Signed-off-by: Joe Slater <jslater at windriver.com>
> ---
>  meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> index 1dad825..5558a59 100644
> --- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> +++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> @@ -35,17 +35,18 @@ MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"
>
>  EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}' 'AR=${AR}'"
>
> -# These features don't compile on mips and libc-musl
> -CFLAGS_mips_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
> -    -DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
> -    -DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
> -CFLAGS_mips64_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
> -    -DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
> -    -DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
> -CFLAGS_append_libc-musl = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
> +lcl_stop_services = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
>      -DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
>      -DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
>
> +
> +# These features don't compile for several cases.
> +#
> +CFLAGS_append_mips = " ${lcl_stop_services}"
> +CFLAGS_append_mips64 = " ${lcl_stop_services}"
> +CFLAGS_append_libc-musl = " ${lcl_stop_services}"
> +CFLAGS_append_powerpc64 = " ${lcl_stop_services}"
> +
>  do_install() {
>         oe_runmake install INSTALLROOT=${D}
>         install -d ${D}${sysconfdir}/init.d/
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core