[OE-core] [morty][PATCH] sstate.bbclass: update .siginfo atime

Martin Jansa martin.jansa at gmail.com
Tue Jun 13 06:21:11 UTC 2017


Unfortunately this nice change breaks quite common scenario when developers
have read-only mount of sstate mirror and this touch causes all _setscene
tasks to fail, because they fail to update atime on symlink which points to
read-only mount.

Please backport the fix for this as well ASAP:
http://git.openembedded.org/openembedded-core/commit/meta/classes/sstate.bbclass?id=b8f26c011d5ed888d85fef040bd821400d54c8fe

On Wed, May 17, 2017 at 1:05 AM, akuster808 <akuster808 at gmail.com> wrote:

>
>
> On 05/16/2017 02:50 PM, Denys Dmytriyenko wrote:
>
>> On Mon, Apr 24, 2017 at 09:08:55AM -0700, akuster808 wrote:
>>
>>> On 04/21/2017 04:18 PM, Denys Dmytriyenko wrote:
>>>
>>>> Ping. It's been over a month now...
>>>>
>>> its in my stagging since 4/1.  The AB has been failing with my
>>> current changes.
>>>
>> Is morty now dead?
>>
>
> No. why do you say that? I just sent a pull request over the weekend for
> both Krogoth and Morty. Krogoth is the one heading to community supported
> now that Pyro is out.
>
> this changes is in the pull request
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commi
> t/meta/classes/sstate.bbclass?h=akuster/morty-next&id=838580
> 431a8923bf38820f10963aca4af51f6f97
>
> - armin
>
>
>
>>
>> On Mon, Mar 20, 2017 at 01:38:20PM -0400, Denys Dmytriyenko wrote:
>>>>
>>>>> From: Ed Bartosh <ed.bartosh at linux.intel.com>
>>>>>
>>>>> .siginfo files are not being accessed from local or NFS-mounted
>>>>> sstate mirrors when sstate package is installed, so their atime
>>>>> is not updated. If sstate mirror is cleaned based on access time,
>>>>> they get deleted, even though they are still being used.
>>>>>
>>>>> Updated atime of .siginfo symlinks with 'touch -a'. This command
>>>>> dereferences symlinks pointing to the local mirror and updates
>>>>> atime of the .siginfo file on the mirror.
>>>>>
>>>>> [YOCTO #10857]
>>>>>
>>>>> Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
>>>>> Signed-off-by: Ross Burton <ross.burton at intel.com>
>>>>> Signed-off-by: Denys Dmytriyenko <denys at ti.com>
>>>>> ---
>>>>>   meta/classes/sstate.bbclass | 2 ++
>>>>>   1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
>>>>> index 8643f3d..4fdfcc8 100644
>>>>> --- a/meta/classes/sstate.bbclass
>>>>> +++ b/meta/classes/sstate.bbclass
>>>>> @@ -724,6 +724,8 @@ python sstate_sign_package () {
>>>>>   #
>>>>>   sstate_unpack_package () {
>>>>>         tar -xvzf ${SSTATE_PKG}
>>>>> +       # update .siginfo atime on local/NFS mirror
>>>>> +       [ -h ${SSTATE_PKG}.siginfo ] && touch -a ${SSTATE_PKG}.siginfo
>>>>>         # Use "! -w ||" to return true for read only files
>>>>>         [ ! -w ${SSTATE_PKG} ] || touch --no-dereference ${SSTATE_PKG}
>>>>>         [ ! -w ${SSTATE_PKG}.sig ] || [ ! -e ${SSTATE_PKG}.sig ] ||
>>>>> touch --no-dereference ${SSTATE_PKG}.sig
>>>>> --
>>>>> 2.7.4
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core at lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>>
>>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170613/32478c69/attachment-0002.html>


More information about the Openembedded-core mailing list