[OE-core] [PATCH v2 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT

Zeeshan Ali (Khattak) zeeshanak at gnome.org
Thu Jun 15 12:59:29 UTC 2017


Hi,

Has this been already merged? I ask cause there is a small change
needed for large-enough rootfs:

> diff --git a/meta/lib/oeqa/controllers/masterimage.py b/meta/lib/oeqa/controllers/masterimage.py
> index 07418fcda1..6cdcfa3068 100644
> --- a/meta/lib/oeqa/controllers/masterimage.py
> +++ b/meta/lib/oeqa/controllers/masterimage.py
> @@ -108,7 +108,7 @@ class MasterImageHardwareTarget(oeqa.targetcontrol.BaseTarget, metaclass=ABCMeta
>              time.sleep(10)
>              self.power_ctl("cycle")
>          else:
> -            status, output = conn.run("reboot")
> +            status, output = conn.run("{ sleep 1; reboot; } > /dev/null &")

Should instead be:

+            status, output = conn.run("sync; { sleep 1; reboot; } >
/dev/null &")

Otherwise, syncing happens as part of reboot (unmounting) and reboot
takes much longer than testing code expect it to and hence fails if it
tries to access/ping the target while reboot is still in progress.

If the patch has been applied, I can send an additional patch;
otherwise I can send a revised version of this patch.

-- 
Regards,

Zeeshan Ali



More information about the Openembedded-core mailing list