[OE-core] [PATCH 01/11] gtk+3: Update the patches to work without PATCHTOOL = "git"

[Peter Kjellerstedt]

> -----Original Message-----
> From: Alexander Kanavin [mailto:alexander.kanavin at linux.intel.com]
> Sent: den 15 juni 2017 16:24
> To: Peter Kjellerstedt <peter.kjellerstedt at axis.com>; Burton, Ross
> <ross.burton at intel.com>
> Cc: OE-core <openembedded-core at lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH 01/11] gtk+3: Update the patches to work
> without PATCHTOOL = "git"
> 
> On 06/15/2017 05:22 PM, Peter Kjellerstedt wrote:
> 
> >>> Well, I am pretty sure Git patches that rename files are not
> supposed
> >>> to be used, since quilt does not support this AFAIK. So the change
> in
> >>> this patch should be correct.
> >>>
> >>> However, I would be more than happy if anyone can explain why
> others
> >>> are not seeing this (or does everyone have PATCHTOOL = "git" in
> their
> >>> configurations somehow?)
> >>
> >> This is unlikely; I certainly don't. Perhaps if you provide the
> exact
> >> command that is being executed, and what is the error it prints, I
> >> could try to do the same?
> >
> > Well, I was running "bitbake core-image-sato", but "bitbake gtk+3"
> should
> > do...
> 
> What I wanted to see is the failing command (quilt, or patch, or what
> is it specifically), and the error you get. gtk+3 is patched and built
> herewith no issues at all.
> 
> Alex

It turns out the problem is only seen if opengl is enabled in 
DISTRO_FEATURES. However, since that is the default for poky, that still 
does not explain why others do not see the problem

I have included the log.do_compile file where one can see that the 
file gdkx-with-gl-context.h is missing (that is the file that was 
supposed to be renamed from gdkx.h by the patch). When I look in 
tmp/work/i586-poky-linux/gtk+3/3.22.15-r0/gtk+-3.22.15/gdk/x11 I see 
gdkx.h and gdkx-without-gl-context.h, instead of the expected 
gdkx-with-gl-context.h and gdkx-without-gl-context.h...

//Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk+3.log
Type: application/octet-stream
Size: 6560 bytes
Desc: gtk+3.log
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170615/03a8f084/attachment-0002.obj>