[OE-core] [PATCH v3] image_types.bbclass: Prompt error message on missing setting in UBI and UBIFS

[Andrea Adami]

On Mon, Jun 19, 2017 at 9:36 PM,  <yin.thong.choong at intel.com> wrote:
> From: Choong YinThong <yin.thong.choong at intel.com>
>
> Prompt error message to guide user add argument
> MKUBIFS_ARGS and UBINIZE_ARGS in local.conf on
> every UBI and UBIFS image creation.
>
> [YOCTO #11589]
>
> Signed-off-by: Choong YinThong <yin.thong.choong at intel.com>
> ---
>  meta/classes/image_types.bbclass | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 7749b00..48338ac 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -145,6 +145,14 @@ UBI_VOLNAME ?= "${MACHINE}-rootfs"
>  multiubi_mkfs() {
>         local mkubifs_args="$1"
>         local ubinize_args="$2"
> +
> +        # Added prompt error message for ubi and ubifs image creation.
> +        if [ -z "$mkubifs_args"] || [ -z "$ubinize_args" ]; then
> +            bberror "MKUBIFS_ARGS and UBINIZE_ARGS argument have to set in local.conf for UBI and UBIFS image creation."

Why in local.conf ? It is not globally valid if you do multi-machine builds.
I'd say the right place is the machine.conf in the BSP layer.

Andrea

> +            bberror "Detail please visit this link http://www.linux-mtd.infradead.org/faq/ubifs.html"
> +            return
> +        fi
> +
>         if [ -z "$3" ]; then
>                 local vname=""
>         else
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core