[OE-core] [PATCH] x86-base.inc: Don't add live to IMAGE_FSTYPES, default instead

[Christopher Larson]

On Tue, Jun 20, 2017 at 5:14 PM, California Sullivan <
california.l.sullivan at intel.com> wrote:

> Using += makes it difficult to remove. Soft-set with ?= instead.
>
> Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
> ---
>  meta/conf/machine/include/x86-base.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/machine/include/x86-base.inc
> b/meta/conf/machine/include/x86-base.inc
> index 7365953..bfacdf5 100644
> --- a/meta/conf/machine/include/x86-base.inc
> +++ b/meta/conf/machine/include/x86-base.inc
> @@ -10,7 +10,7 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2
> ext3 x86 \
>
>  MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
>
> -IMAGE_FSTYPES += "live"
> +IMAGE_FSTYPES ?= "live"
>

I’m assuming you verified that none of the existing machines including this
were depending on the += behavior to add to the current value? And this
would almost certainly result in a different default for any machines that
don’t adjust IMAGE_FSTYPES at all, since it’d be adding to the bitbake.conf
or distro default.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170621/a76ae389/attachment-0002.html>