[OE-core] [PATCH v5] image_types.bbclass: Prompt error message on missing setting in UBI and UBIFS

[Burton, Ross]

On 21 June 2017 at 20:06, <yin.thong.choong at intel.com> wrote:

> +        if [ -z "$mkubifs_args"] || [ -z "$ubinize_args" ]; then
> +            bberror "MKUBIFS_ARGS and UBINIZE_ARGS argument have to set
> for UBI and UBIFS image creation."
> +            bberror "Detail please visit this link http://www.linux-mtd.
> infradead.org/faq/ubifs.html"
> +            return
> +        fi
>

bberror isn't fatal but this is a fatal problem so the task needs to fail.
You could emit the first line with bberror and the second with bbfatal, but
its would be clearer if it was one line, such as:

bbfatal "MKUBIFS_ARGS and UBINIZE_ARGS have to be set, see
http://www.linux-mtd.infradead.org/faq/ubifs.html for details"

As bbfatal does an exit, there's no need for the return either.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170622/a24f2d8f/attachment-0002.html>