[OE-core] [PATCH] cmake: Use find_program if find_host_program is not available
Otavio Salvador
otavio.salvador at ossystems.com.br
Mon Jun 26 19:41:34 UTC 2017
On Mon, Jun 26, 2017 at 3:33 PM, Maxime Roussin-Bélanger
<maxime.roussinbelanger at gmail.com> wrote:
> CMake does not define the `find_host_program` command we've
> been using in the cross-compiling code path. It was
> provided by a widely used Android toolchain file. For
> compatibility, continue to use `find_host_program` if
> available, but otherwise use just `find_program`.
>
> Signed-off-by: Maxime Roussin-Bélanger <maxime.roussinbelanger at gmail.com>
It sounds fine to me; the backward compatibility is maintained and it
fixes a real use-case so I see no reason to not apply EXCEPT:
- lack of Upstream-Status field
- lack of upstream bug about the issue, ideally the proposed patch
should be send to upstream so we can drop it in next releases
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
More information about the Openembedded-core
mailing list