[OE-core] [PATCH v2] bitbake.conf: Add sdl-config to HOSTTOOLS if using host SDL

[Jonathan Liu]

Hi Richard,

On 27 June 2017 at 22:54, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Tue, 2017-06-27 at 11:05 +0200, Patrick Ohly wrote:
>> On Thu, 2017-06-01 at 22:15 +1000, Jonathan Liu wrote:
>> >
>> > If ASSUME_PROVIDES contains libsdl-native, we need to add sdl-
>> > config
>> > to HOSTTOOLS to allow access to the host sdl-config.
>> >
>> > Signed-off-by: Jonathan Liu <net147 at gmail.com>
>> > ---
>> >  meta/conf/bitbake.conf | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> > index 8e4f4bbb56..3ad905c917 100644
>> > --- a/meta/conf/bitbake.conf
>> > +++ b/meta/conf/bitbake.conf
>> > @@ -471,6 +471,9 @@ HOSTTOOLS += " \
>> >  # Tools needed to run testimage runtime image testing
>> >  HOSTTOOLS += "ip ping ps scp ssh stty"
>> >
>> > +# Link to sdl-config if using host SDL
>> > +HOSTTOOLS += "${@bb.utils.contains('ASSUME_PROVIDES', 'libsdl-
>> > native', 'sdl-config', '', d)}"
>> > +
>> Why are you checking ASSUME_PROVIDES? The variable is called
>> ASSUME_PROVIDED.
>>
>> Even if you had checked the right variable, is that really necessary?
>> I'm building qemu with ASSUME_PROVIDED += "libsdl-native" just fine
>> on Debian Jessie, without sdl-config in HOSTTOOLS.
>>
>> Sorry for the late reply, going through my backlog... I see that this
>> has been merged. Probably needs to be reverted or fixed.
>
> I've reverted this since I can't see how it can actually work or help
> anything, unless someone has set "ASSUME_PROVIDES" to test this (which
> is a variable that doesn't exist or is used anywhere).
>
> Cheers,
>
> Richard

It is a typo. The fix is in ross/mut -
http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=ross/mut&id=7605eb1e507d4ebc0c5b8d98a358be7c55e4ddd2.

Regards,
Jonathan