[OE-core] [PATCH 2/3] scriptutils: pass in logger as parameter
Chang Rebecca Swee Fun
rebecca.swee.fun.chang at intel.com
Wed Jun 28 01:59:18 UTC 2017
logger was not defined in scriptutils.py based on the
observation in python traceback.
Traceback (most recent call last):
File "/workdir/poky/scripts/devtool", line 351, in <module>
ret = main()
File "/workdir/poky/scripts/devtool", line 338, in main
ret = args.func(args, config, basepath, workspace)
File "/workdir/poky/scripts/lib/devtool/utilcmds.py", line 55, in
edit_recipe
return scriptutils.run_editor(find_recipe(args, config, basepath,
workspace))
File "/workdir/poky/scripts/lib/scriptutils.py", line 141, in
run_editor
logger.error("Execution of '%s' failed: %s" % (editor, exc))
NameError: name 'logger' is not defined
We pass in logger as parameter to run_editor() from where it has
been called (devtool/utilcmds.py and recipetool/newappend.py),
which both modules already has logger setup.
Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang at intel.com>
---
scripts/lib/devtool/utilcmds.py | 2 +-
scripts/lib/recipetool/newappend.py | 2 +-
scripts/lib/scriptutils.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/lib/devtool/utilcmds.py b/scripts/lib/devtool/utilcmds.py
index 0437e64..938d88a 100644
--- a/scripts/lib/devtool/utilcmds.py
+++ b/scripts/lib/devtool/utilcmds.py
@@ -49,7 +49,7 @@ def edit_recipe(args, config, basepath, workspace):
raise DevtoolError("Recipe file for %s is not under the workspace" %
args.recipename)
- return scriptutils.run_editor(recipefile)
+ return scriptutils.run_editor(recipefile, logger)
def configure_help(args, config, basepath, workspace):
diff --git a/scripts/lib/recipetool/newappend.py b/scripts/lib/recipetool/newappend.py
index 0b63759..decce83 100644
--- a/scripts/lib/recipetool/newappend.py
+++ b/scripts/lib/recipetool/newappend.py
@@ -74,7 +74,7 @@ def newappend(args):
return 1
if args.edit:
- return scriptutils.run_editor([append_path, recipe_path])
+ return scriptutils.run_editor([append_path, recipe_path], logger)
else:
print(append_path)
diff --git a/scripts/lib/scriptutils.py b/scripts/lib/scriptutils.py
index 2b3f3fc..c2539a3 100644
--- a/scripts/lib/scriptutils.py
+++ b/scripts/lib/scriptutils.py
@@ -123,7 +123,7 @@ def fetch_uri(d, uri, destdir, srcrev=None):
shutil.rmtree(tmpworkdir)
return ret
-def run_editor(fn):
+def run_editor(fn, logger=None):
if isinstance(fn, str):
params = '"%s"' % fn
else:
--
2.7.4
More information about the Openembedded-core
mailing list