[OE-core] [PATCH v2 1/6] yocto-compat-layer.py: avoid adding layers more than once

[Patrick Ohly]

On Tue, 2017-06-27 at 15:46 -0700, Christopher Larson wrote:
> 
> On Tue, Jun 27, 2017 at 8:33 AM, Patrick Ohly <patrick.ohly at intel.com>
> wrote:
>         add_layer_dependencies() might get called more than once, or
>         one of
>         the layer dependencies might already be present. The function
>         should
>         not add layers again because doing so can cause warnings like:
>         
>           WARNING: Duplicate inclusion
>         for .../meta-openembedded/meta-oe/conf/distro/include/meta_oe_security_flags.inc in .../meta-openembedded/meta-oe/conf/layer.conf
>         
>         Signed-off-by: Patrick Ohly <patrick.ohly at intel.com>
>         ---
> 
> I’m curious about why this isn’t either just calling out to
> `bitbake-layers add-layer` or using one of the existing functions we
> have for modifying bblayers, rather than doing its own +=.

I don't know exactly, Mark implemented it like that. My guess is that
more control was needed over which layers get added. For example,
"bitbake-layers add-layer" only adds one layer, but does not recursively
add layers it depends on. This could be improved of course.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.