[OE-core] [PATCH] gcc-source: rewrite do_preconfigure() in shell

Richard Purdie richard.purdie at linuxfoundation.org
Thu Mar 2 16:21:37 UTC 2017


On Thu, 2017-03-02 at 16:16 +0000, Ross Burton wrote:
> This function is essentially just four lines of shell, that for some
> reason was
> written in Python.
> 
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
> meta/recipes-devtools/gcc/gcc-source.inc | 25 +++++++++++-----------

I suspect this will break in the various signature checks and cause
rebuilds when things shouldn't.

http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/?id=f07b7c0da1748afc35fbb2ead7ae10ec66c7c428

hints at why:

"It needs to be a python task to avoid lots of shell exported variables as dependencies."

which should of course be a comment in the code.

I wish we had a better way to control exported variables to shell tasks
which would be a better fix but right now we don't.

Cheers,

Richard



More information about the Openembedded-core mailing list