[OE-core] [PATCH] terminal: Use original PATH for terminals

[Khem Raj]

On Mon, Mar 13, 2017 at 2:41 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> Now that we filter out PATH to only the utilities we rely upon, the devshel
> terminal was broken since it can no longer find the terminals. Even if
> we fix that, the user couldn't access any of their commands within
> devshell which somewhat defeats its purpose.
>
> Add the original PATH back to the environment to restore that behaviour
> since this is more in line with user expectations and it wouldn't be possible
> (or desireable) to whitelist all the commands a user might want to use from
> the shell.
>

will this also mean that it will now, inject original PATH into builds done
using seashell ?

> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> ---
>  meta/classes/terminal.bbclass | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta/classes/terminal.bbclass b/meta/classes/terminal.bbclass
> index 62409c0..a27e10c 100644
> --- a/meta/classes/terminal.bbclass
> +++ b/meta/classes/terminal.bbclass
> @@ -66,6 +66,11 @@ def oe_terminal(command, title, d):
>              envdata.setVar(key, str(value))
>              envdata.setVarFlag(key, 'export', '1')
>
> +    # Use original PATH as a fallback
> +    path = d.getVar('PATH') + ":" + origbbenv.getVar('PATH')
> +    os.environ['PATH'] = path
> +    envdata.setVar('PATH', path)
> +
>      # A complex PS1 might need more escaping of chars.
>      # Lets not export PS1 instead.
>      envdata.delVar("PS1")
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core