[OE-core] [PATCH] image_types: perform fsck on created ext image

[Enrico Joerns]

Hi Daniel,

On 03/24/2017 02:34 PM, Daniel Schultz wrote:
> Hi Enrico,
>
> I have sent fixes for the same problem on Monday.
> These include a fix of the wrong return code after optimizations (now it
> returns 0) and an fsck execution after the creation of EXT partitions.
>
> The patch which is identical to yours wasn't applied so far, the other
> ones were.

ouh, we should have checked that before, but we did not assume that 
someone would have posted a fix for this relatively old behavior during 
the last days. Reality disabused us... Anyway, good to see that we are 
not the only one that stumbled across this issue ;)

But, there is another difference between our patches. We use `-pvfD`, 
while you use `-fy` as an fsck.extN option.

I would expect `-p` to be sufficient for letting fsck perform minor 
optimizations. If you use `-y` instead, fsck will fix also real issues. 
This is not what it should do here, even if it will return 1 afterwards. 
If the file system was created with errors I guess we should let the 
image creation fail without further touching the ext4.

-D will let fsck perform further directory optimizations
-v might be helpful for debugging purpose


Best regards

Enrico

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5080 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |