[OE-core] [PATCH] image_types: perform fsck on created ext image

[Enrico Joerns]

Hi Daniel,

On 03/27/2017 09:37 AM, Daniel Schultz wrote:
>>> I have sent fixes for the same problem on Monday.
>>> These include a fix of the wrong return code after optimizations (now it
>>> returns 0) and an fsck execution after the creation of EXT partitions.
>>>
>>> The patch which is identical to yours wasn't applied so far, the other
>>> ones were.
>>
>> ouh, we should have checked that before, but we did not assume that
>> someone would have posted a fix for this relatively old behavior during
>> the last days. Reality disabused us... Anyway, good to see that we are
>> not the only one that stumbled across this issue ;)
>>
>> But, there is another difference between our patches. We use `-pvfD`,
>> while you use `-fy` as an fsck.extN option.
>>
>> I would expect `-p` to be sufficient for letting fsck perform minor
>> optimizations. If you use `-y` instead, fsck will fix also real issues.
>> This is not what it should do here, even if it will return 1 afterwards.
>> If the file system was created with errors I guess we should let the
>> image creation fail without further touching the ext4.
>>
>> -D will let fsck perform further directory optimizations
>> -v might be helpful for debugging purpose
>>
> Yes, that's better. I will them also apply to the WIC tools.
>
> Do you think the test expression is still needed?
> My opinion is, that it will obfuscate the return code of fsck to either
> true or false. This could confuse other people. What do you think?

well, as far as I see it, the test expression will only be needed if 
fsck still returns an error code for those uncritical optimizations it 
performs. With the backported patch applied you had in your series i 
guess there should be no need for the test expression, but I did not 
test it yet in this setup.

Best regards, Enrico

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5080 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |