[OE-core] [PATCH] libxslt: Add PACKAGECONFIG support for python

[Patel, Vedang]

Hi Andre, Ross,

On Thu, 2017-03-23 at 18:39 -0700, Andre McCurdy wrote:
>  On Thu, Mar 23, 2017 at 5:00 PM, Vedang Patel <vedang.patel at intel.co
> m> wrote:
> > 
> > Add support to enable python bindings for libxslt using
> > PACKAGECONFIG.
> > This will include --with-python argument while compiling the
> > package.
> > The support is disabled by default.
> > 
> > Signed-off-by: Vedang Patel <vedang.patel at intel.com>
> > ---
> >  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > index be747e608d9d..707f2f97b7fc 100644
> > --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
> > 
> >  BINCONFIG = "${bindir}/xslt-config"
> > 
> > -inherit autotools pkgconfig binconfig-disabled lib_package
> > +inherit autotools pkgconfig binconfig-disabled lib_package
> > distutils-common-base
> > 
> >  # We don't DEPEND on binutils for ansidecl.h so ensure we don't
> > use the header
> >  do_configure_prepend () {
> > @@ -33,7 +33,9 @@ do_configure_prepend () {
> >         touch ${S}/doc/xsltproc.1
> >  }
> > 
> > -EXTRA_OECONF = "--without-python --without-debug --without-mem-
> > debug --without-crypto"
> > +EXTRA_OECONF = "--without-debug --without-mem-debug --without-
> > crypto"
> > +PACKAGECONFIG[python] = "--with-python=${PYTHON_BASE_VERSION}, --
> > without-python"
> The more conventional way to order these lines would be:
> 
>   PACKAGECONFIG ?= ""
>   PACKAGECONFIG[python] = "--with-python=${PYTHON_BASE_VERSION},
> --without-python"
> 
>   EXTRA_OECONF = "--without-debug --without-mem-debug --without-
> crypto"
> 
> The python PACKAGECONFIG option probably needs to include a
> dependency
> on python.
> 
I will make the proposed changes in the arrangement of the statements.

Regarding the python dependency, the feedback from Andre is the
opposite of what Ross gave me in one of the previous emails where he
told not to include the python dependency in PACKAGECONFIG. He asked to
make sure that the python module is packaged seperately. (Just FYI:
 Here, libxslt has a hard dependency on python-2.7.)

Also, the --with-python argument will only adding python bindings to
libxslt. Is it a good idea  to move that to a subpackage? If so, can
you point me to a good example for that

Thanks,
Vedang Patel
Software Engineer
Intel Corporation
> > 
> >  # older versions of this recipe had ${PN}-utils
> >  RPROVIDES_${PN}-bin += "${PN}-utils"
> >  RCONFLICTS_${PN}-bin += "${PN}-utils"
> > --
> > 2.7.3
> > 
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core