[OE-core] [PATCH] systemd: check 'efi' in MACHINE_FEATURES

[Peter Kjellerstedt]

For the record, this is just correcting a regression that was introduced with my change to use bb.utils.filter() where I apparently missed that not all the features were DISTRO_FEATURES…

That said, I do agree that it would be preferable to get rid of the machine specific dependency if possible.

//Peter

From: openembedded-core-bounces at lists.openembedded.org [mailto:openembedded-core-bounces at lists.openembedded.org] On Behalf Of Burton, Ross
Sent: den 29 mars 2017 18:01
To: Mikko Ylinen
Cc: OE-core
Subject: Re: [OE-core] [PATCH] systemd: check 'efi' in MACHINE_FEATURES


On 29 March 2017 at 10:26, Mikko Ylinen <mikko.ylinen at linux.intel.com<mailto:mikko.ylinen at linux.intel.com>> wrote:
The recipe checks 'efi' in DISTRO_FEATURES but it's a machine feature.

Fix the check to use MACHINE_FEATURES to determine whether to
enable/disable 'efi' PACKAGECONFIG.

This makes systemd a MACHINE-specific recipe, and as it contains libudev causes rebuilds for everything linking to that.  What's the actual impact of enabling/disabling EFI?

There is a whitelist for recipes which are machine-specific but should be treated as tune, but the barrier to get on that list is high.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170329/36368bb3/attachment-0002.html>