[OE-core] [PATCH v5] oeqa/sdk/cases:Adds validation for SDK compatibility tests

[Burton, Ross]

On 30 March 2017 at 00:12, Francisco Pedraza <
francisco.j.pedraza.gonzalez at intel.com> wrote:

> @@ -9,7 +9,9 @@ class GalculatorTest(OESDKTestCase):
>      @classmethod
>      def setUpClass(self):
>          if not (self.tc.hasTargetPackage("gtk+3") or\
> -                self.tc.hasTargetPackage("libgtk-3.0")):
> +                self.tc.hasTargetPackage("libgtk-3.0") or
> +                self.tc.hasTargetPackage("gtk") or
> +                self.tc.hasTargetPackage("matchbox-config-gtk")):
>              raise unittest.SkipTest("GalculatorTest class: SDK don't
> support gtk+3")
>

Why is this checking for what appears to be gtk+v2 ("gtk") or
matchbox-config-gtk (an application that shouldn't be in a SDK)?


> @@ -17,7 +17,9 @@ class BuildIptablesTest(OESDKTestCase):
>
>          machine = self.td.get("MACHINE")
>
> -        if not self.tc.hasHostPackage("packagegroup-cross-canadian-%s" %
> machine):
> +        if not (self.tc.hasTargetPackage("packagegroup-cross-canadian-%s"
> % machine) or
> +                self.tc.hasTargetPackage("gcc-runtime") or
> +                self.tc.hasTargetPackage("libgcc")):
>              raise unittest.SkipTest("SDK doesn't contain a cross-canadian
> toolchain")
>

Seems a very long-winded way of checking that a compiler is present...

@@ -8,7 +8,10 @@ from oeqa.sdk.case import OESDKTestCase
>  class PerlTest(OESDKTestCase):
>      @classmethod
>      def setUpClass(self):
> -        if not self.tc.hasHostPackage("nativesdk-perl"):
> +        if not (self.tc.hasHostPackage("nativesdk-perl") or
> +                self.tc.hasHostPackage("perl-native") or
> +                self.tc.hasHostPackage("libperl5") or
> +                self.tc.hasHostPackage("perl")):
>              raise unittest.SkipTest("No perl package in the SDK")
>

As this is a test for the nativesdk part of the SDK, why does it care about
target (perl) or native (perl-native) packages?

         for f in ['test.pl']:
> diff --git a/meta/lib/oeqa/sdk/cases/python.py b/meta/lib/oeqa/sdk/cases/
> python.py
> index 94a296f..29705bf 100644
> --- a/meta/lib/oeqa/sdk/cases/python.py
> +++ b/meta/lib/oeqa/sdk/cases/python.py
> @@ -8,7 +8,10 @@ from oeqa.sdk.case import OESDKTestCase
>  class PythonTest(OESDKTestCase):
>      @classmethod
>      def setUpClass(self):
> -        if not self.tc.hasHostPackage("nativesdk-python"):
> +        if not (self.tc.hasHostPackage("nativesdk-python") or
> +                self.tc.hasHostPackage("python-smartpm-native") or
> +                self.tc.hasHostPackage("nativesdk-python3")):



Aside from the fact that oe-core master has recently moved from smart to
DNF, and Python2 to Python3, why does a test that just runs a basic Python
command care about smartpm?

Also the test also now checks for nativesdk-python3 but executes python,
which is python v2.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170330/5bc33426/attachment-0002.html>