[OE-core] [PATCH] QemuRunner: avoid tainting os.environ

Burton, Ross ross.burton at intel.com
Wed May 3 12:00:33 UTC 2017


On 3 May 2017 at 12:53, Patrick Ohly <patrick.ohly at intel.com> wrote:

> Then it wouldn't get logged. Not a particularly strong argument, though.
> If that's preferred, I can change the implementation.
>

I prefer the clarity of copying os.environ and adding to it over running
env, especially as you have whitespace/quoting to deal with.  The variables
added to the environment could easily be logged separately, surely?

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170503/6b168b36/attachment-0002.html>


More information about the Openembedded-core mailing list