[OE-core] [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

Patrick Ohly patrick.ohly at intel.com
Mon May 15 08:32:29 UTC 2017


Activating API documentation with:
  INHERIT += "manpages"
  DISTRO_FEATURES_append = " api-documentation"
triggers QA warnings for each recipe which doesn't have a "manpages"
PACKAGECONFIG. Example:
  WARNING: base-files-3.0.14-r89 do_configure: QA Issue: base-files: invalid PACKAGECONFIG: manpages [invalid-packageconfig]

We need to be more selective when adding the "manpages" feature and check
whether it's supported first.

Signed-off-by: Patrick Ohly <patrick.ohly at intel.com>
---
 meta/classes/manpages.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/manpages.bbclass b/meta/classes/manpages.bbclass
index d16237b..5aa1d1a 100644
--- a/meta/classes/manpages.bbclass
+++ b/meta/classes/manpages.bbclass
@@ -2,4 +2,5 @@
 # depending on whether 'api-documentation' is in DISTRO_FEATURES. Such building
 # tends to pull in the entire XML stack and other tools, so it's not enabled
 # by default.
-PACKAGECONFIG_append_class-target = " ${@bb.utils.contains('DISTRO_FEATURES', 'api-documentation', 'manpages', '', d)}"
+PACKAGECONFIG_append_class-target = "${@ '' if 'manpages' not in d.getVarFlags('PACKAGECONFIG') else \
+    bb.utils.contains('DISTRO_FEATURES', 'api-documentation', ' manpages', '', d)}"

base-commit: c59fa3bd71b42410bf032846ee8fdb6e6eb1b95c
-- 
git-series 0.9.1



More information about the Openembedded-core mailing list