[OE-core] [PATCH] tzcode-native: quote ${CC}

[Christopher Larson]

On Thu, May 18, 2017 at 2:54 PM, Denys Dmytriyenko <denis at denix.org> wrote:

> On Thu, May 18, 2017 at 02:37:29PM -0700, Christopher Larson wrote:
> > On Thu, May 18, 2017 at 11:57 AM, Khem Raj <raj.khem at gmail.com> wrote:
> >
> > > On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko <denis at denix.org>
> > > wrote:
> > > > On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote:
> > > >> build fails else with
> > > >>
> > > >> | + make -j 8 -l 6 cc=ccache gcc
> > > >> | make: *** No rule to make target 'gcc'.  Stop.
> > > >>
> > > >> Signed-off-by: Enrico Scholz <enrico.scholz at sigma-chemnitz.de>
> > > >> ---
> > > >>  meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
> > > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > >> index 2084f79..165d2c6 100644
> > > >> --- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > >> +++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > >> @@ -18,7 +18,7 @@ S = "${WORKDIR}"
> > > >>
> > > >>  inherit native
> > > >>
> > > >> -EXTRA_OEMAKE += "cc=${CC}"
> > > >> +EXTRA_OEMAKE += "cc='${CC}'"
> > > >
> > > > Should these be double-quotes around ${CC}?
> > >
> > > I think this should work as such.
> >
> > Indeed, it’s expanded by bitbake, not the shell, so which quotes don’t
> > matter in that regard, and it’s syntactically cleaner to use different
> > quotes than those used for the variable as a whole.
>
> Unless ${CC} has shell variables inside for later expansion, isn't it?


IMO doing so is a bug, as it relies on particulars of precisely when and
where the shell variable is expanded. Doing so often results in having to
escape it a precise number of times, depending on what context where you
want it expanded. More trouble than it’s worth, in my opinion. *shrug*
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170518/d4c4fc83/attachment-0002.html>