[OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

Alexander Kanavin alexander.kanavin at linux.intel.com
Mon May 22 13:08:07 UTC 2017


On 05/19/2017 06:48 PM, Max Krummenacher wrote:
> +   # check if rpm contains a bundled berkeley db
> +-  CHECK_INCLUDE_FILE(rpm/db.h HAVE_RPM_DB_H)
> ++  CHECK_LIBRARY_EXISTS(rpm.so db_create_rpmdb "" HAVE_RPM_DB_H)

Sorry Max, this is actually worse than the first version. HAVE_RPM_DB_H 
has to accurately reflect the presence or absence of the header, as that 
header is later included or not included depending on that. You cannot 
set it based on checking some library.

So please either fix CHECK_INCLUDE_FILE, or let's revert to the first 
version of the patch, as it at least doesn't introduce a new issue.

Alex



More information about the Openembedded-core mailing list