[OE-core] [PATCH 1/2] systemctl-native: add target.wants to target regex

[Martin Kelly]

Got it, thanks. My patch *should* just convert runtime failures into 
compile-time failures, but it looks like we're seeing actual runtime 
failures, so I'll try to figure out what happened.

On 11/08/2017 12:31 PM, Burton, Ross wrote:
> Thanks for reminding me.  :)
> 
> 1/2 is queued but 2/2 was implicated in a number of systemd-related boot 
> failures on the autobuilder 
> (https://autobuilder.yocto.io/builders/nightly-qa-extras/builds/553).
> 
> I've not yet got around to looking at exactly what sanity test 5 and 7 
> do to trigger this.
> 
> Ross
> 
> On 8 November 2017 at 17:40, Martin Kelly <mkelly at xevo.com 
> <mailto:mkelly at xevo.com>> wrote:
> 
>     (ping) for this patch series.
> 
>     On 10/16/2017 09:31 AM, Martin Kelly wrote:
> 
>         The regex for acceptable systemd WantedBy/RequiredBy targets
>         does not include
>         target.wants, so a line like this:
> 
>         WantedBy=multi-user.target.wants
> 
>         gets silently ignored, even though it works fine on a real system.
> 
>         Signed-off-by: Martin Kelly <mkelly at xevo.com
>         <mailto:mkelly at xevo.com>>
>         ---
>            meta/recipes-core/systemd/systemd-systemctl/systemctl | 2 +-
>            1 file changed, 1 insertion(+), 1 deletion(-)
> 
>         diff --git
>         a/meta/recipes-core/systemd/systemd-systemctl/systemctl
>         b/meta/recipes-core/systemd/systemd-systemctl/systemctl
>         index efad14ce17..6e5a1b7181 100755
>         --- a/meta/recipes-core/systemd/systemd-systemctl/systemctl
>         +++ b/meta/recipes-core/systemd/systemd-systemctl/systemctl
>         @@ -108,7 +108,7 @@ for service in $services; do
>                  # If any new unit types are added to systemd they
>         should be added
>                  # to this regular expression.
>         -     
>           unit_types_re='\.\(service\|socket\|device\|mount\|automount\|swap\|target\|path\|timer\|snapshot\)\s*$'
>         +     
>           unit_types_re='\.\(service\|socket\|device\|mount\|automount\|swap\|target\|target\.wants\|path\|timer\|snapshot\)\s*$'
>                  if [ "$action" = "preset" ]; then
>                          action=`egrep -sh  $service
>         $ROOT/etc/systemd/user-preset/*.preset | cut -f1 -d' '`
>                          if [ -z "$action" ]; then
> 
>     -- 
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core at lists.openembedded.org
>     <mailto:Openembedded-core at lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
> 
>