[OE-core] [meta][PATCH 1/2] Fix some issues in the fitImage generation

André Draszik git at andred.net
Fri Nov 10 10:30:54 UTC 2017


Hi Manju,

This one isn't the latest version, but even the latest versions had issues
reported by patchtest. So I guess no.

Cheers,
Andr'

On Thu, 2017-11-09 at 17:28 +0000, Manjukumar Harthikote Matha wrote:
> Hi All,
> 
> Is this accepted in master? We need similar patch in Rocko and I have an
> additional do_deploy failure fix patch on top of this patch.
> 
> Thanks,
> Manju
> 
> From: openembedded-core-bounces at lists.openembedded.org [mailto:openembedde
> d-core-bounces at lists.openembedded.org] On Behalf Of Thomas PERROT
> Sent: Wednesday, October 25, 2017 9:18 PM
> To: André Draszik <git at andred.net>
> Cc: OE-core <openembedded-core at lists.openembedded.org>
> Subject: Re: [OE-core] [meta][PATCH 1/2] Fix some issues in the fitImage
> generation
> 
> Hi,
> 
> I agree, so I cleaned up, split into several commits, then superseded this
> one.
> Best regards,
> Thomas P.
> 
> On Wed, Oct 25, 2017 at 1:06 PM, André Draszik <git at andred.net<mailto:git@
> andred.net>> wrote:
> On Wed, 2017-10-25 at 11:13 +0100, André Draszik wrote:
> > On Wed, 2017-10-25 at 09:32 +0200, Thomas Perrot wrote:
> > > - Bad image type replacement for aarch64
> > > - Fix DTB path in fitimage.its
> > 
> > It doesn't look like the DTB bit is still relevant in this commit.
> > 
> > > - Ignore fitImage type in do_bundle_initramfs task because the
> > > packaging
> > > is made by do_assemble_fitimage_initramfs
> > > - the images for arm64 are not compressed the linux_comp variable must
> > > therefore be none
> > 
> > I think it would also make sense to split this into multiple commits, as
> > your aarch64 fixes and fitimage fixes aren't directly related.
> 
> To be more clear, your fix to kernel.bbclass is independent of everything
> else and doesn't apply to aarch64 only, so it should be a separate commit.
> 
> 
> Cheers,
> Andre'
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org<mailto:Openembedded-core at lists.op
> enembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 



More information about the Openembedded-core mailing list