[OE-core] [PATCH 13/23] package_manager.py: reverse archs correctly
Alexander Kanavin
alexander.kanavin at linux.intel.com
Mon Nov 13 09:04:42 UTC 2017
On 11/13/2017 10:40 AM, Robert Yang wrote:
>> Can you place all of this in a helper function please?
>
> Thanks, updated in the repo:
> + self._arch_reverse_helper()
Don't make the helper update class variables. It makes the code hard to
understand or reason about. Instead, call like this:
self.archs = _determine_archs(arch_var)
and do the rest in the helper. So that self.archs is assigned to only once.
Alex
More information about the Openembedded-core
mailing list