[OE-core] [PATCH 13/23] package_manager.py: reverse archs correctly

[Alexander Kanavin]

On 11/13/2017 12:23 PM, Robert Yang wrote:
> 
> 
> On 11/13/2017 05:04 PM, Alexander Kanavin wrote:
>> On 11/13/2017 10:40 AM, Robert Yang wrote:
>>>> Can you place all of this in a helper function please?
>>>
>>> Thanks, updated in the repo:
>>> +        self._arch_reverse_helper()
>>
>> Don't make the helper update class variables. It makes the code hard 
>> to understand or reason about. Instead, call like this:
>>
>> self.archs = _determine_archs(arch_var)
>>
>> and do the rest in the helper. So that self.archs is assigned to only 
>> once.
> 
> Thanks, updated in the repo:

Looks good now, thank you.

Alex