[OE-core] [PATCH] oeqa/selftest/runtime_test: fix postinst_rootfs_and_boot

[Burton, Ross]

On 14 November 2017 at 12:06, Patrick Ohly <patrick.ohly at intel.com> wrote:

> On Mon, 2017-11-06 at 17:55 +0000, Ross Burton wrote:
> >                     testcommand = 'ls /etc/' + fileboot_name
>
> Can't this be removed?
>
> >                      with runqemu('core-image-minimal') as qemu:
> > -                        ssh = SSHControl(ip=qemu.ip,
> logfile=qemu.sshlog)
> > -                        status, output = ssh.run(testcommand)
> > +                        status, output = qemu.run_serial("-f /etc/" +
> fileboot_name)
>
> Did you mean "test -f"?


Yes! Argh.


>
> >                          self.assertEqual(status, 0, 'File %s was not
> created at first boot (%s)' % (fileboot_name, output))
>
> run_serial has the quirk that status == 1 on *success*. Yes, weird.
>

Oh <redacted>.



> The test probably passed because it was testing for failure, and the
> missing "test" ensured that the command failed.
>

Thanks.  Sorry.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20171114/d6986948/attachment-0002.html>