[OE-core] [PATCH 2/2] install*.sh: add short sleep after parted commands
Saul Wold
sgw at linux.intel.com
Tue Nov 21 22:27:53 UTC 2017
On Tue, 2017-11-21 at 13:47 -0800, California Sullivan wrote:
> I wasn't able to install to my Optane SSD due to the following error:
>
> Formatting /dev/nvme0n1p1 to vfat...
> mkfs.fat 4.1 (2017-01-24)
> mkfs.vfat: unable to open /dev/nvme0n1p1: No such file or directory
> Target install-efi failed
>
> A couple lines later I see:
>
> [ 10.265401] nvme0n1: p1 p2 p3
>
> Then looking at the device itself after booting from a USB stick:
>
> root at intel-corei7-64: ~# ls /dev/nvme0n1*
> /dev/nvme0n1 /dev/nvme0n1p1 /dev/nvme0n1p2 /dev/nvme0n1p3
>
> So it looks like the parted commands return before the device node is
> actually created.
>
> Work around this issue by adding a short sleep before doing the mkfs
> commands.
>
Not advisable to just add the sleep, maybe a check before to see if the
device exists and then sleep (or usleep, if we have it) and do this in
a while loop with a counter to actually timeout after some number of
sleeps.
Yes more work, but more appropriate if the settle time is not actually
needed or a longer settle time is required.
Thanks
Sau!
> Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
> ---
> meta/recipes-core/initrdscripts/files/init-install-efi.sh | 2 ++
> meta/recipes-core/initrdscripts/files/init-install.sh | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/meta/recipes-core/initrdscripts/files/init-install-
> efi.sh b/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> index 5ad3a60..118bf08 100644
> --- a/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> +++ b/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> @@ -186,6 +186,8 @@ parted ${device} mkpart swap linux-swap
> $swap_start 100%
>
> parted ${device} print
>
> +sleep 1
> +
> echo "Formatting $bootfs to vfat..."
> mkfs.vfat $bootfs
>
> diff --git a/meta/recipes-core/initrdscripts/files/init-install.sh
> b/meta/recipes-core/initrdscripts/files/init-install.sh
> index 1cac806..606317d 100644
> --- a/meta/recipes-core/initrdscripts/files/init-install.sh
> +++ b/meta/recipes-core/initrdscripts/files/init-install.sh
> @@ -211,6 +211,8 @@ parted ${device} mkpart $pname linux-swap
> $swap_start 100%
>
> parted ${device} print
>
> +sleep 1
> +
> echo "Formatting $bootfs to ext3..."
> mkfs.ext3 $bootfs
>
> --
> 2.9.5
>
More information about the Openembedded-core
mailing list