[OE-core] [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir

[Bruce Ashfield]

On Sun, Nov 26, 2017 at 5:44 PM, Saul Wold <sgw at linux.intel.com> wrote:

> On Wed, 2017-11-22 at 15:51 -0500, Bruce Ashfield wrote:
> > On 2017-11-22 1:47 PM, Saul Wold wrote:
> > > Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR (kernel-
> > > build-artifacts)
> > > before creating it, otherwise there might be older artifacts from a
> > > prior
> > > kernel build.
> > >
> >
> > What's the actual error that this triggers ? It would be nice to
> > log it here in the commit message .. or at least a description
> > of the symptoms.
> >
> As refered to in the bug, there is not an actual error occurs, but
> there are multiple older and non-appropriate (read older) artifacts
> remaining in the kernel-build-artifacts directory, just as the commit
> message describes.
>

Quoting a bug isn't useful .. everything that someone needs to know
*must* be in a commit message. I'm not clicking through later on
when doing a 'git whatchanged', and I may not even be online at
that time .. so that bug reference just isn't useful.

So the old artifacts remain .. is it a disk usage question ? Is it a
possible
confusion when inspecting a build ? .. All that the message does is
describe the change, not the why.

Bruce



>
> Sau!
>
> > > [YOCTO #11880]
> > >
> > > Signed-off-by: Saul Wold <sgw at linux.intel.com>
> > > ---
> > >   meta/classes/kernel.bbclass | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/meta/classes/kernel.bbclass
> > > b/meta/classes/kernel.bbclass
> > > index 756707a3c25..2a0a7707a14 100644
> > > --- a/meta/classes/kernel.bbclass
> > > +++ b/meta/classes/kernel.bbclass
> > > @@ -400,6 +400,7 @@ emit_depmod_pkgdata() {
> > >
> > >   PACKAGEFUNCS += "emit_depmod_pkgdata"
> > >
> > > +do_shared_workdir[cleandirs] += " ${STAGING_KERNEL_BUILDDIR}"
> > >   do_shared_workdir () {
> > >     cd ${B}
> > >
> > > @@ -655,8 +656,6 @@ kernel_do_deploy() {
> > >             fi
> > >     done
> > >   }
> > > -do_deploy[cleandirs] = "${DEPLOYDIR}"
> > > -do_deploy[dirs] = "${DEPLOYDIR} ${B}"
> >
> > This isn't clear to me. Why does cleaning the STAGING_KERNEL_BUILDDIR
> > as part of the do_shared_workdir mean that we no longer need the
> > clean before the deploy (as well as the deploy dir).
> >
> > Bruce
> >
> > >   do_deploy[prefuncs] += "package_get_auto_pr"
> > >
> > >   addtask deploy after do_populate_sysroot do_packagedata
> > >
> >
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20171126/b9759d8e/attachment-0002.html>