[OE-core] [PATCH] recipes-graphics/piglit: Add patch for fix build in HiKey platforms

[Randy MacLeod]

On 2017-11-24 11:52 AM, Aníbal Limón wrote:
> From: Aníbal Limón <anibal.limon at linaro.org>
> 
> Some EGL implementations do not actually ship all Khronos-extensions.
> As it turns out, the Mali 450 driver does not include eglGetPlatformDisplay
> symbol so there is not grauntee to exists use piglit_egl_get_default_display

Anibal,

First, my grammar OCD corrections,   :)

s/grauntee/guarantee/

and more generally:
   so there is not guarantee ...
   so there is no guarantee that it exists,
      use piglit_egl_get_default_display

or just use the upstream commit log:
     The entry point is not guaranteed to exist, so use the
     piglit_egl_get_default_display() helper which does the
     correct thing.


This a backport of 45095dc08b from the piglet git repo
so please make that clear in the long log as well.

Thanks,

../Randy


> wrapper instead.
> 
> Signed-off-by: Aníbal Limón <anibal.limon at linaro.org>
> Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> ---
>   ...gl-context-priority.c-Use-piglit_egl_get_.patch | 39 ++++++++++++++++++++++
>   meta/recipes-graphics/piglit/piglit_git.bb         |  1 +
>   2 files changed, 40 insertions(+)
>   create mode 100644 meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch
> 
> diff --git a/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch
> new file mode 100644
> index 0000000000..6b73950fc1
> --- /dev/null
> +++ b/meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch
> @@ -0,0 +1,39 @@
> +From 3b6c3abe3698abb0ae08d14a399eea29805cafd6 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <anibal.limon at linaro.org>
> +Date: Fri, 24 Nov 2017 10:11:42 -0600
> +Subject: [PATCH] tests/egl/egl-context-priority.c: Use
> + piglit_egl_get_default_display
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Some EGL implementations do not actually ship all Khronos-extensions.
> +As it turns out, the Mali 450 driver does not include eglGetPlatformDisplay
> +symbol so there is not grauntee to exists use piglit_egl_get_default_display
> +wrapper instead. See rev 45095dc08b.
> +
> +Signed-off-by: Aníbal Limón <anibal.limon at linaro.org>
> +Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> +
> +Upstream-Status: Submitted [piglit at lists.freedesktop.org]
> +---
> + tests/egl/egl-context-priority.c | 3 +--
> + 1 file changed, 1 insertion(+), 2 deletions(-)
> +
> +diff --git a/tests/egl/egl-context-priority.c b/tests/egl/egl-context-priority.c
> +index 7f26fc614..9590ccae3 100644
> +--- a/tests/egl/egl-context-priority.c
> ++++ b/tests/egl/egl-context-priority.c
> +@@ -99,8 +99,7 @@ piglit_init(int argc, char **argv)
> + 	if (!strstr(exts, "EGL_MESA_platform_surfaceless"))
> + 		piglit_report_result(PIGLIT_SKIP);
> +
> +-	dpy = eglGetPlatformDisplay(EGL_PLATFORM_SURFACELESS_MESA,
> +-				    EGL_DEFAULT_DISPLAY, NULL);
> ++	dpy = piglit_egl_get_default_display(EGL_PLATFORM_SURFACELESS_MESA);
> +
> + 	ok = eglInitialize(dpy, &major, &minor);
> + 	if (!ok) {
> +--
> +2.11.0
> +
> diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb
> index eae3eed342..c6d4e5c6e0 100644
> --- a/meta/recipes-graphics/piglit/piglit_git.bb
> +++ b/meta/recipes-graphics/piglit/piglit_git.bb
> @@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b2beded7103a3d8a442a2a0391d607b0"
>   SRC_URI = "git://anongit.freedesktop.org/piglit \
>              file://0001-cmake-install-bash-completions-in-the-right-place.patch \
>              file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch \
> +           file://0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch \
>              "
>   
>   # From 2017-02-06
> 


-- 
# Randy MacLeod.  WR Linux
# Wind River an Intel Company