[OE-core] [PATCH] site: consolidate ac_cv_func_mmap_fixed_mapped definitions

Ross Burton ross.burton at intel.com
Tue Nov 28 16:23:52 UTC 2017


This is the cache variable used by AC_FUNC_MMAP, which is possibly one of the
worst autoconf macros to exist.

Apart from being a runtime test which silently claims that mmap() is broken when
cross-compiling, this is basically to verify that mmap() actually works, because
SVR4.0 (released 1988) was broken.  Thirty years later, everyone has a working
mmap().

common-glibc already has an assignment, so add a corresponding assignment to
common-musl and remove it from the machine-specific files.

Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/site/arm-linux   | 1 -
 meta/site/common-musl | 1 +
 meta/site/ix86-common | 1 -
 meta/site/nios2-linux | 1 -
 meta/site/sh-common   | 1 -
 5 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/meta/site/arm-linux b/meta/site/arm-linux
index e6b9a726fb0..7bf073eb779 100644
--- a/meta/site/arm-linux
+++ b/meta/site/arm-linux
@@ -142,7 +142,6 @@ samba_cv_LINUX_LFS_SUPPORT=${samba_cv_LINUX_LFS_SUPPORT=yes}
 clamav_av_func_working_snprintf_long=${clamav_av_func_working_snprintf_long=yes}
 clamav_av_have_in_port_t=${clamav_av_have_in_port_t=yes}
 clamav_av_have_in_addr_t=${clamav_av_have_in_addr_t=yes}
-ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes}
 
 #dbus
 ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}
diff --git a/meta/site/common-musl b/meta/site/common-musl
index 26fc1033191..1b4fc321353 100644
--- a/meta/site/common-musl
+++ b/meta/site/common-musl
@@ -12,6 +12,7 @@ ac_cv_func_getpwuid_r=${ac_cv_func_getpwuid_r=yes}
 ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getpwuid_r=yes}
 ac_cv_func_posix_getgrgid_r=${ac_cv_func_posix_getgrgid_r=yes}
 ac_cv_func_getaddrinfo=${ac_cv_func_getaddrinfo=yes}
+ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes}
 
 # glib
 glib_cv_strlcpy=${glib_cv_strlcpy=no}
diff --git a/meta/site/ix86-common b/meta/site/ix86-common
index 4fbf58c0cfd..c5e354c073a 100644
--- a/meta/site/ix86-common
+++ b/meta/site/ix86-common
@@ -53,7 +53,6 @@ bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}
 clamav_av_func_working_snprintf_long=${clamav_av_func_working_snprintf_long=yes}
 clamav_av_have_in_port_t=${clamav_av_have_in_port_t=yes}
 clamav_av_have_in_addr_t=${clamav_av_have_in_addr_t=yes}
-ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes}
 
 # cvs
 cvs_cv_func_printf_ptr=${cvs_cv_func_printf_ptr=yes}
diff --git a/meta/site/nios2-linux b/meta/site/nios2-linux
index 5bae7484346..24bc5b033a1 100644
--- a/meta/site/nios2-linux
+++ b/meta/site/nios2-linux
@@ -372,7 +372,6 @@ samba_cv_LINUX_LFS_SUPPORT=${samba_cv_LINUX_LFS_SUPPORT=yes}
 clamav_av_func_working_snprintf_long=${clamav_av_func_working_snprintf_long=yes}
 clamav_av_have_in_port_t=${clamav_av_have_in_port_t=yes}
 clamav_av_have_in_addr_t=${clamav_av_have_in_addr_t=yes}
-ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes}
 
 #dbus
 ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}
diff --git a/meta/site/sh-common b/meta/site/sh-common
index fc4d6ad792d..97c96934d71 100644
--- a/meta/site/sh-common
+++ b/meta/site/sh-common
@@ -227,7 +227,6 @@ with_broken_putenv=${with_broken_putenv=no}
 clamav_av_func_working_snprintf_long=${clamav_av_func_working_snprintf_long=yes}
 clamav_av_have_in_port_t=${clamav_av_have_in_port_t=yes}
 clamav_av_have_in_addr_t=${clamav_av_have_in_addr_t=yes}
-ac_cv_func_mmap_fixed_mapped=${ac_cv_func_mmap_fixed_mapped=yes}
 
 # libnet 
 ac_cv_lbl_unaligned_fail=${ac_cv_lbl_unaligned_fail=no}
-- 
2.11.0




More information about the Openembedded-core mailing list