[OE-core] About auto-upgrade-helper's enhancement

[Alexander Kanavin]

On 11/30/2017 04:23 AM, Robert Yang wrote:
> I tried auto-upgrade-helper, it is very helpful when upgrade recipes.
> I'd like to make some enhancements to make it can be easily used by the
> maintainer (recipe upgrader) himself:

Great, let's make it awesome :)

> 1) Don't send email when maintainer uses it, for example, when I want to
>     upgrade "strace", I don't need it send email to anyone.

I think email sending can be easily disabled in the configuration, no?

> 2) Use git's user.name and user.email in git commit when not send email,
>     we need let the maintainer take responsible for it.

You can reset the commit authorship via 'git commit --amend 
--reset-author', but I wouldn't want automatically created commits to 
have my name by default, especially when mass-creating them.

> 3) Do the commit on the recipes when the upgrade is succeed, currently,
>     it keeps the commit when failed, but removed it when succeed.

Yes. In fact I've deleted all code that does branch and commit 
manipulation, except the part that creates commits. The tool shouldn't 
decide for the user how to manage branches, and on which branch to base 
the work (currently hardcoded to master) etc.

> 4) Make upgradehelper.py can accept multiple recipes as args.

Yep.

> 5) It's a small tool and helpful when upgrade recipes, can we move it into
>     oe-core/scripts, please ?

I agree, after it's been ported to use devtool and I'm happy with how it 
works.

Alex