[OE-core] [PATCH] cross.bbclass: Remove usage of host flags for cross-compilation
Khem Raj
raj.khem at gmail.com
Fri Oct 6 16:40:47 UTC 2017
On Fri, Oct 6, 2017 at 9:11 AM, Nikolai Merinov
<n.merinov at inango-systems.com> wrote:
> So, it will be better to keep TARGET_LDFLAGS empty by default?
I think yes.
>
> 6 октября 2017 г. 18:55:02 GMT+05:00, Khem Raj <raj.khem at gmail.com> пишет:
>>
>> On Thu, Oct 5, 2017 at 1:02 AM, Nikolay Merinov
>> <n.merinov at inango-systems.com> wrote:
>>>
>>> BUILD_* flags can't be used as TARGET_* flags even for "cross" packages.
>>>
>>> gcc-cross buils leaks config.log's through "gcc-stashed-builddir" and
>>> TARGET_* flags to libgcc cross-build through "gcc/libgcc.mvars" file
>>> on "gcc-stashed-builddir". This means that if BUILD_CFLAGS contains
>>> host-specific flags like "-isystem/usr/include" libgcc build will
>>> fail "do_qa_configure" and "do_package_qa" checks.
>>>
>>> Remove host-related flags from TARGET_* flags for gcc-cross build.
>>>
>>> Signed-off-by: Nikolay Merinov <n.merinov at inango-systems.com>
>>> ---
>>> meta/classes/cross.bbclass | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/meta/classes/cross.bbclass b/meta/classes/cross.bbclass
>>> index 4887317a9a..29d4424829 100644
>>> --- a/meta/classes/cross.bbclass
>>> +++ b/meta/classes/cross.bbclass
>>> @@ -28,10 +28,10 @@ MULTIMACH_TARGET_SYS =
>>> "${BUILD_ARCH}${BUILD_VENDOR}-${BUILD_OS}"
>>> export PKG_CONFIG_DIR = "${exec_prefix}/lib/pkgconfig"
>>> export PKG_CONFIG_SYSROOT_DIR = ""
>>>
>>> -TARGET_CPPFLAGS = "${BUILD_CPPFLAGS}"
>>> -TARGET_CFLAGS = "${BUILD_CFLAGS}"
>>> -TARGET_CXXFLAGS = "${BUILD_CXXFLAGS}"
>>> -TARGET_LDFLAGS = "${BUILD_LDFLAGS}"
>>> +TARGET_CPPFLAGS = ""
>>> +TARGET_CFLAGS = ""
>>> +TARGET_CXXFLAGS = ""
>>> +TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE}"
>>
>>
>>
>> I think using TARGET_LINK_HASH_STYLE could create target specific
>> dependency on cross packages, which might not be an issue for gcc but
>> could be issue for other cross packages.
>>
>>> CPPFLAGS = "${BUILD_CPPFLAGS}"
>>> CFLAGS = "${BUILD_CFLAGS}"
>>> --
>>> 2.14.2
>>>
>>> --
>>> ________________________________
>>>
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
> --
> Nikolay Merinov
> Team Leader, 3-rd Party Group
> n.merinov at inango-systems.com
> T +7 343 298 0147 C +7 912 229 2564
> inango.com
More information about the Openembedded-core
mailing list