[OE-core] [PATCH] cmake: fix typo in toolchain file

Øystein Walle oystwa at gmail.com
Tue Oct 10 12:38:34 UTC 2017


On 10 October 2017 at 14:31, Maciej Borzęcki <maciej.borzecki at rndity.com> wrote:
> On Tue, Oct 10, 2017 at 2:25 PM, Alexander Kanavin
>
>> Where is the typo and what is it, exactly?
>
> -set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
>
> missing _ between CMAKE and ASM

Correct. As it is the code defines a variable named "CMAKE" with the
contents "ASM_FLAGS ${CMAKE_C_FLAGS}". As far as CMake is concerned that
is valid and so this will not generate any form of error, but may
result in incorrect flags.

I can resend the patch with a better commit message if you like.

--
Øsse



More information about the Openembedded-core mailing list