[OE-core] [PATCH] go: update to go1.9.1

Khem Raj raj.khem at gmail.com
Tue Oct 10 22:42:42 UTC 2017


On Tue, Oct 10, 2017 at 1:36 PM, Matt Madison <matt at madison.systems> wrote:
> On Tue, Oct 10, 2017 at 9:40 AM, Khem Raj <raj.khem at gmail.com> wrote:
>> On Tue, Oct 10, 2017 at 9:28 AM, Burton, Ross <ross.burton at intel.com> wrote:
>>> On 10 October 2017 at 12:05, Matt Madison <matt at madison.systems> wrote:
>>>>
>>>> +PV = "1.9.1"
>>>
>>>
>>> Surely having a go-1.9.bb which then sets PV=1.9.1 is confusing at best?
>>> Why not just update the checksums and rename the files?
>>>
>>
>> I think its in line with what we do with rest of toolchain.
>
> Yes, the pattern has already been long established in the gcc recipes, anyway.
>
>>                     Probably
>>
>> MINOR = ".1"
>>
>> PV = "{BASE_PV}${MINOR}"
>>
>> might be better.
>
> I'm not sure I understand this.  Where would BASE_PV come from?

it was sort pseudo code, but you already have GO_BASEVERSION which is
what BASE_PV stood for.

>
> I'm also fine with just renaming the recipes, .inc file, and
> subdirectory for the patches, if that's deemed preferable.
>
> Thanks,
> -Matt
>
>>
>>> Ross
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>



More information about the Openembedded-core mailing list