[OE-core] [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
Martin Jansa
martin.jansa at gmail.com
Thu Oct 12 01:56:09 UTC 2017
On Mon, Oct 09, 2017 at 09:09:31AM +0000, git at git.openembedded.org wrote:
> This is an automated email from the git hooks/post-receive script.
>
> rpurdie pushed a commit to branch master
> in repository openembedded-core.
>
> commit 8ca61a5464743ff85b6d26886112750d6ddd13e0
> Author: Chen Qi <Qi.Chen at windriver.com>
> AuthorDate: Sat Sep 30 16:15:42 2017 +0800
>
> bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
>
> Add tools required by testimage to HOSTTOOLS only when testimage is
> inherited. These tools, as described in the comment, are only required
> by the testimage task. So this change should not have negtive effect.
> This would also solve build error on hosts which miss some tool such as scp.
>
> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> ---
> meta/conf/bitbake.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 6f53b23..0eefb86 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
> "
>
> # Tools needed to run testimage runtime image testing
> -HOSTTOOLS += "ip ping ps scp ssh stty"
> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
Shouldn't we include at least ssh by default?
I have some builds where CONNECTIVITY_CHECK_URIS contains private git repo (to make sure that users
configured their git + ssh correctly before starting the build) and since this change it fails, because
of missing ssh:
ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
Following is the list of potential problems / advisories:
Fetcher failure: Fetch command export PATH="...snip.../hosttools"; export HOME="/home/jenkins"; git -c core.fsyncobjectfiles=0 ls-remote ssh://foo.com/bar/repo failed with exit code 128, output:
error: cannot run ssh: No such file or directory
fatal: unable to fork
.
Please ensure your host's network is configured correctly,
or set BB_NO_NETWORK = "1" to disable network access if
all required sources are on local disk.
I know I can add ssh locally, but do we really need to be so strict
here? We already include git and git might need ssh.
Regards,
> # Link to these if present
> HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
>
> --
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
--
Martin 'JaMa' Jansa jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20171012/305f7460/attachment-0002.sig>
More information about the Openembedded-core
mailing list