[OE-core] [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally

[Paul Eggleton]

On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
> > On Mon, Oct 09, 2017 at 09:09:31AM +0000, git at git.openembedded.org wrote:
> >> --- a/meta/conf/bitbake.conf
> >> +++ b/meta/conf/bitbake.conf
> >> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
> >>  "
> >>
> >>  # Tools needed to run testimage runtime image testing
> >> -HOSTTOOLS += "ip ping ps scp ssh stty"
> >> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
> >
> > Shouldn't we include at least ssh by default?
> 
> I would say no, since nothing in OE-Core depends on it. more we
> abstract from host system better it is.

I'm with Martin on this one, let's not make it painful for people to use
the SSH protocol in git URLs in their recipes. I don't see much potential
for host contamination.

Cheers,
Paul


-- 

Paul Eggleton
Intel Open Source Technology Centre